Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra includes in ostream exporter test #2252

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Aug 1, 2023

Got added from #2229

@lalitb lalitb requested a review from a team August 1, 2023 16:37
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2252 (0fe86a1) into main (8c82d24) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2252   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         198      198           
  Lines        5856     5856           
=======================================
  Hits         5131     5131           
  Misses        725      725           
Files Changed Coverage Δ
exporters/ostream/test/ostream_log_test.cc 96.23% <ø> (ø)

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

@lalitb lalitb merged commit b7fd057 into open-telemetry:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants