Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Increase metric name maximum length from 63 to 255 characters #2284

Merged
merged 1 commit into from
Aug 31, 2023
Merged

[SDK] Increase metric name maximum length from 63 to 255 characters #2284

merged 1 commit into from
Aug 31, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Aug 31, 2023 •
edited
Loading

Fixes #2281

Changes

  • Increased metric name max length to 255 (in regexp and non regexp code)
  • Removed unused attribute Meter::instrument_metadata_validator

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team August 31, 2023 13:45
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2284 (110ee31) into main (7196ec3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2284   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         199      199           
  Lines        5981     5981           
=======================================
  Hits         5234     5234           
  Misses        747      747
Files Changed Coverage
sdk/include/opentelemetry/sdk/metrics/meter.h ø
sdk/src/metrics/instrument_metadata_validator.cc ø

esigo
esigo approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks:)

@marcalff marcalff merged commit f52ec6c into open-telemetry:main Aug 31, 2023
@marcalff marcalff deleted the fix_metric_name_2281 branch September 5, 2023 15:00
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2023
Merged
@duncanpo duncanpo mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esigo esigo esigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK] Increase metric name maximum length from 63 to 255 characters
2 participants
@marcalff @esigo