Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix GetLogger with empty library name #2398

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Nov 10, 2023

Fixes #2397

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team November 10, 2023 00:16
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #2398 (2aef6fa) into main (35a9362) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2398      +/-   ##
==========================================
- Coverage   87.43%   87.43%   -0.00%     
==========================================
  Files         199      199              
  Lines        6030     6028       -2     
==========================================
- Hits         5272     5270       -2     
  Misses        758      758              
Files Coverage Δ
sdk/src/logs/logger_provider.cc 90.91% <100.00%> (-0.39%) ⬇️

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@marcalff marcalff changed the title Fix GetLogger with empty library name [SDK] Fix GetLogger with empty library name Nov 10, 2023
@marcalff marcalff merged commit 86ee886 into open-telemetry:main Nov 10, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetLogger doesn't return the expected logger if empty library name is in the arguments
4 participants