-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEMANTIC CONVENTIONS] Upgrade to semconv version 1.23.1 #2428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Difficult to identify the difference due to the change in the order of definitions. Hopefully, the generate script should be good to rely on. Else, let me know if something needs to be reviewed specifically.
Yes, relying on the generated code too. I think the build-tools can be improved to may be sort all symbols first, to generate them in a more predictable and stable order, to limit spurious diffs ... I will raise that with build-tools. I use a smoke test to check the diff sanity, looked ok:
it will list a lot of semconv with +1 and -1 lines for the same name, indicating the declaration moved but was unchanged. |
Agree, a more predictable order would help. |
Fixes #2419
Changes
Upgrade to:
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes