Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Remove gmock from GTEST_BOTH_LIBRARIES #2437

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Dec 7, 2023

Based on this CMake doc, GTEST_BOTH_LIBRARIES should just be gtest and gtest_main. gmock should be not included.

I found that there is linking ambiguity if both gtest and gmock are linked to a test dynamically, like the gtest UnitTest are registered to the static registries in gmock DLL, and make the tests not discoverable later by gtest.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #2437 (cb93e9c) into main (4bd64c9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2437   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6087     6087           
=======================================
  Hits         5299     5299           
  Misses        788      788           

@ThomsonTan ThomsonTan marked this pull request as ready for review December 7, 2023 04:28
@ThomsonTan ThomsonTan requested a review from a team December 7, 2023 04:28
@marcalff marcalff merged commit a8b11a3 into open-telemetry:main Dec 7, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants