[BUILD] Remove gmock from GTEST_BOTH_LIBRARIES #2437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this CMake doc,
GTEST_BOTH_LIBRARIES
should just be gtest and gtest_main. gmock should be not included.I found that there is linking ambiguity if both gtest and gmock are linked to a test dynamically, like the gtest
UnitTest
are registered to the static registries in gmock DLL, and make the tests not discoverable later by gtest.Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes