Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Accept path list in OPENTELEMETRY_EXTERNAL_COMPONENT_PATH #2439

Conversation

ThomsonTan
Copy link
Contributor

@ThomsonTan ThomsonTan commented Dec 7, 2023

Extend OPENTELEMETRY_EXTERNAL_COMPONENT_PATH to support path list will help integration with multiple external exporters.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #2439 (8821bf8) into main (cd626c2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2439   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6087     6087           
=======================================
  Hits         5299     5299           
  Misses        788      788           

@ThomsonTan ThomsonTan marked this pull request as ready for review December 7, 2023 23:38
@ThomsonTan ThomsonTan requested a review from a team December 7, 2023 23:38
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit suggestions

@ThomsonTan ThomsonTan merged commit 96e5078 into open-telemetry:main Dec 8, 2023
45 checks passed
@ThomsonTan ThomsonTan deleted the build_with_multiple_external_components branch December 8, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants