[EXPORTER] Change OTLP HTTP content_type default to binary #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@kkuehl thanks for the contribution. Could you please sign the CLA? |
lalitb
reviewed
Jan 9, 2024
|
Thanks for working on it. Also, please add the changelog as this is supposed to be a breaking change. |
ExportBinaryIntegrationTest
I have signed the CLA (twice now), but I assume there is a manual step? |
marcalff
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
- Coverage 87.06% 87.04% -0.01%
==========================================
Files 199 199
Lines 6087 6087
==========================================
- Hits 5299 5298 -1
- Misses 788 789 +1 |
marcalff
reviewed
Jan 9, 2024
|
/easycla |
|
About the CLA, somehow the system sees two accounts : @kkuehl and @kirby-mimic Please make sure you sign the CLA for the proper account. This needs to be resolved, as we can not merge a PR without it. Start over and create another clean PR if you have to. |
kkuehl
pushed a commit
to kkuehl/opentelemetry-cpp
that referenced
this pull request
Jan 10, 2024
This is a new PR with correct identity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/open-telemetry/opentelemetry-proto/blob/main/docs/specification.md
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes