-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROTO] Upgrade to opentelemetry-proto v1.1.0 #2488
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2488 +/- ##
==========================================
+ Coverage 87.06% 87.09% +0.04%
==========================================
Files 199 200 +1
Lines 6087 6103 +16
==========================================
+ Hits 5299 5315 +16
Misses 788 788
|
exporters/etw/include/opentelemetry/exporters/etw/etw_random_id_generator.h
Outdated
Show resolved
Hide resolved
set IsRandom flag to false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
* Set the trace flags of the span. | ||
* @param flags the flags to set | ||
*/ | ||
virtual void SetTraceFlags(opentelemetry::trace::TraceFlags flags) noexcept = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a breaking change. Why not provide a no-op default implementation?
virtual void SetTraceFlags(opentelemetry::trace::TraceFlags flags) noexcept {};
Fixes #2487
Prepare for #2283
Changes
Please provide a brief description of the changes here.
OtlpRecordable::SetTraceFlags()
IsRandom()
property in classIdGenerator
.IsRandom
trace flags.Currently, the specs complies with W3C Trace Context version 1, so that
IsRandom
is ignored.When adoption of W3C Trace Context version 2 is effective, the implementation of
Tracer::StartSpan()
will need to change 1 line of code (usingkAllW3CTraceContext2Flags
instead ofkAllW3CTraceContext1Flags
) to complete the implementation of #2283For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes