-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] OTLP file exporter #2540
Conversation
This PR is ready to be reviewed now. @open-telemetry/cpp-approvers @perhapsmaple |
Hi @owent, thanks for doing this. This is a very nice and well done PR. I have a couple of questions for now:
We will have to test it with the Thanks |
Thanks.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work, as we are used to.
See some minor changes or comments.
Need to resolve my 3 comments, and need a second reviewer: adding the please-review label. |
Done |
Nice work. Can we document this exporter as an section in README.md ? |
Sorry for the missing. I will add documents |
Merging this PR now, please open a PR later for some doc when you have time. Thanks for this work. |
Fixes #2482
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes