[SEMANTIC CONVENTIONS] Rework on semantic conventions 1.25.0 #2640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
This fix is a follow up on #2633.
Context:
service.name
are no longer defined in resources.registry
as attribute_groups.service.name
defined in the registryWhen generating resource semantic conventions,
the code generation does not fail when a unknown reference to
service.name
is found,which seems a bug for build tools, and the semantic convention
opentelemetry::sdk::resource::SemanticConventions::kServiceName
is not generated.This causes a breaking change for instrumented applications.
Changes:
This fix changes the command used to generate resource semantic conventions,
to use
resource,attribute_group
instead ofresource
, so that attributes groups definitions are availableto the code generation.
When invoking the code generator with
resource,attribute_group
,the symbol
opentelemetry::sdk::resource::SemanticConventions::kServiceName
is generated.With this fix, instrumented application code is unchanged (previous changes using
trace::SemanticConventions::kServiceName
as a work around have been reverted)For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes