-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bazel] Enable --incompatible_disallow_empty_glob #2642
[bazel] Enable --incompatible_disallow_empty_glob #2642
Conversation
This way downstream consumers can enable this flag as well
I have a list in my soft fork, with few more incompatbiles that were enabled (whatever I can) - https://github.com/malkia/opentelemetry-cpp/blob/main/.bazelrc#L92 - although that specifically did not work - I think it was for the prometheus-cpp module? |
depends on jupp0r/prometheus-cpp#715 and probably some other stuff |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 195 195
Lines 6151 6151
=======================================
Hits 5404 5404
Misses 747 747
|
This PR in prometheus-cpp: is merged, but there is no release yet that includes it. Opentelemetry-cpp is using the prometheus-cpp 1.2.4 tag. Waiting on release 1.2.5 from prometheus (adding blocked tag) |
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
will rebase after #3162 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
This way downstream consumers can enable this flag as well