Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Enable --incompatible_disallow_empty_glob #2642

Conversation

keith
Copy link
Contributor

@keith keith commented Apr 19, 2024

This way downstream consumers can enable this flag as well

This way downstream consumers can enable this flag as well
@keith keith requested a review from a team April 19, 2024 20:16
@malkia
Copy link

malkia commented Apr 20, 2024

I have a list in my soft fork, with few more incompatbiles that were enabled (whatever I can) - https://github.com/malkia/opentelemetry-cpp/blob/main/.bazelrc#L92 - although that specifically did not work - I think it was for the prometheus-cpp module?

@keith keith marked this pull request as draft May 23, 2024 23:09
@keith
Copy link
Contributor Author

keith commented May 23, 2024

depends on jupp0r/prometheus-cpp#715 and probably some other stuff

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (6a77bcd) to head (f0af970).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2642   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         195      195           
  Lines        6151     6151           
=======================================
  Hits         5404     5404           
  Misses        747      747           
---- 🚨 Try these New Features:

@marcalff
Copy link
Member

marcalff commented Jun 12, 2024

depends on jupp0r/prometheus-cpp#715 and probably some other stuff

This PR in prometheus-cpp:

is merged, but there is no release yet that includes it.

Opentelemetry-cpp is using the prometheus-cpp 1.2.4 tag.

Waiting on release 1.2.5 from prometheus (adding blocked tag)

@marcalff marcalff added the issue:blocked Fix blocked, waiting for other fixes as prerequisites label Jun 12, 2024
@github-actions github-actions bot added Stale and removed Stale labels Aug 13, 2024
@marcalff
Copy link
Member

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit f0af970
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67412ad8eba1a1000814eff1

@marcalff marcalff removed the issue:blocked Fix blocked, waiting for other fixes as prerequisites label Nov 4, 2024
@keith
Copy link
Contributor Author

keith commented Nov 22, 2024

will rebase after #3162

@keith keith marked this pull request as ready for review November 23, 2024 01:22
@keith keith requested a review from a team as a code owner November 23, 2024 01:22
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 9d998e3 into open-telemetry:main Nov 23, 2024
57 checks passed
@keith keith deleted the ks/bazel-enable-incompatible_disallow_empty_glob branch November 23, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants