-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2661
Merged
marcalff
merged 2 commits into
open-telemetry:main
from
hongweipeng:fix-random-memory-leak
Jul 19, 2024
Merged
[SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2661
marcalff
merged 2 commits into
open-telemetry:main
from
hongweipeng:fix-random-memory-leak
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongweipeng
force-pushed
the
fix-random-memory-leak
branch
from
May 7, 2024 08:29
e6b5f8b
to
c2ce0fb
Compare
hongweipeng
force-pushed
the
fix-random-memory-leak
branch
3 times, most recently
from
May 8, 2024 04:02
cdffe88
to
9ebc698
Compare
ThomsonTan
reviewed
May 8, 2024
hongweipeng
force-pushed
the
fix-random-memory-leak
branch
from
May 8, 2024 06:59
9ebc698
to
e665d74
Compare
hongweipeng
force-pushed
the
fix-random-memory-leak
branch
from
May 19, 2024 10:20
be00d4d
to
6b44492
Compare
owent
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marcalff
changed the title
Fix memory leak in TlsRandomNumberGenerator() constructor #2660
[SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2660
Jul 19, 2024
marcalff
changed the title
[SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2660
[SDK] Fix memory leak in TlsRandomNumberGenerator() constructor
Jul 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
==========================================
+ Coverage 87.12% 87.60% +0.49%
==========================================
Files 200 190 -10
Lines 6109 5870 -239
==========================================
- Hits 5322 5142 -180
+ Misses 787 728 -59
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2660
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes