-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Fix sync problems in OTLP File exporter tests. #3031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the test cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change looks ok, but the test still fails under valgrind.
There must be another root cause to fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
==========================================
+ Coverage 87.12% 87.60% +0.49%
==========================================
Files 200 190 -10
Lines 6109 5870 -239
==========================================
- Hits 5322 5142 -180
+ Misses 787 728 -59 |
|
I have not found anything either. Let's merge this, in hope that the next failure will bring more information about the root cause. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge.
This will help narrow the root cause, so it can be better investigated.
[TEST] Fix sync problems in OTLP File exporter tests. (open-telemetry#3031)
* [EXPORTER] Ignore exception when create thread in OTLP file exporter. (open-telemetry#3012) * [BUILD] Update MODULE.bazel (open-telemetry#3015) * [BUILD] Fix build without vcpkg on Windows when gRPC is disabled (open-telemetry#3016) * [BUILD] Add abi_version_no bazel flag. (open-telemetry#3020) * [Code health] Expand iwyu coverage to include unit tests. (open-telemetry#3022) * [BUILD] Version opentelemetry_proto/proto_grpc shared libraries (open-telemetry#2992) * [SEMANTIC CONVENTIONS] Upgrade semantic conventions to 1.27.0 (open-telemetry#3023) * [SDK] Support empty histogram buckets (open-telemetry#3027) * support empty buckets * Update histogram_test.cc * Update histogram_test.cc * test for negative values * fix count * [TEST] Fix sync problems in OTLP File exporter tests. (open-telemetry#3031) --------- Co-authored-by: WenTao Ou <owentou@tencent.com> Co-authored-by: Carbo Kuo <BYVoid@users.noreply.github.com> Co-authored-by: Manuel Bergler <m.bergler@tum.de> Co-authored-by: Marc Alff <marc.alff@oracle.com> Co-authored-by: Troels Hoffmeyer <Troels.d.hoffmeyer@gmail.com> Co-authored-by: Lalit Kumar Bhasin <lalit_fin@yahoo.com>
Fixes #3025
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes