-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update otel-collector version #3067
Conversation
|
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
+ Coverage 87.12% 87.78% +0.66%
==========================================
Files 200 195 -5
Lines 6109 5953 -156
==========================================
- Hits 5322 5225 -97
+ Misses 787 728 -59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted, thanks for the fix.
Please:
- upgrade to the most recent opentelemetry-collector version
- update file
ci/do_ci.sh
as well, it should fix recent benchmark failures.
Looks like otel-collector equal or higher than 0.86.0 has the "debug" exporter. So updated the README.md with the latest version of the otel-collector (v0.109.0) and also the CI script.
714bd9a
to
5633006
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
[CI] Update otel-collector version (open-telemetry#3067)
Looks like otel-collector equal or higher than 0.86.0 has the "debug" exporter.