-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] Fix crash in ElasticsearchLogRecordExporter #3082
[EXPORTER] Fix crash in ElasticsearchLogRecordExporter #3082
Conversation
using constructor with user given options (open-telemetry#3078) Closes open-telemetry#3078
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3082 +/- ##
==========================================
+ Coverage 87.12% 87.82% +0.71%
==========================================
Files 200 195 -5
Lines 6109 5968 -141
==========================================
- Hits 5322 5241 -81
+ Misses 787 727 -60 |
Thanks @ShadowMaxLeb for the patch. Please sign the contributor agreement (CLA), so this PR can be merged to the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Thanks for the contribution. This PR is approved and ready to be merged to the main branch.
Please allow maintainers to make edits (there is a checkbox in the github UI for that), or perform a main -> PR merge so we can take it. Thanks. |
Added the merge conflict tag.
|
Since the fork ispart of an organization, it seems that I do not have the possibility to allow maintainers (https://github.com/orgs/community/discussions/5634). I will update the PR. |
Fixes #3078
Using constructor with user provided options in
ElasticsearchLogRecordExporter
was making the program crash due tosynchronization_data_
not being intialized when built with async behavior (-DWITH_ASYNC_EXPORT_PREVIEW=ON
)Changes
Constructors have been changed so the default one always calls the one with options as parameters to ensure to always initialize everything.