-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEMANTIC CONVENTIONS] Migration to weaver #3105
[SEMANTIC CONVENTIONS] Migration to weaver #3105
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3105 +/- ##
==========================================
+ Coverage 87.12% 87.85% +0.73%
==========================================
Files 200 195 -5
Lines 6109 6136 +27
==========================================
+ Hits 5322 5390 +68
+ Misses 787 746 -41
|
Reviewers: Generated codeCode under api/include/opentelemetry/semconv is generated automatically. Make sure to review at least:
Weaver generationAll relevant code is under buildscripts/semantic-convention. Please review:
Example of usageVarious examples, tests, sdk files have been updated, and now use the new semconv generated code. |
@open-telemetry/weaver-maintainers @open-telemetry/cpp-maintainers Please review, and provide feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice use of Weaver. Thank you for this migration.
buildscripts/semantic-convention/templates/registry/schema_url-h.j2
Outdated
Show resolved
Hide resolved
buildscripts/semantic-convention/templates/registry/weaver.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on it.
Fixes #3089
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes