-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] Log SSL Connection Information #3113
[EXPORTER] Log SSL Connection Information #3113
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
2b36b33
to
b2e4069
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3113 +/- ##
==========================================
+ Coverage 87.12% 87.85% +0.73%
==========================================
Files 200 195 -5
Lines 6109 6138 +29
==========================================
+ Hits 5322 5392 +70
+ Misses 787 746 -41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for the feature.
Reusing console_debug for this is a good idea.
See some comments or questions, with approval to follow once resolved.
e58cafd
to
109efdd
Compare
109efdd
to
2ed8e0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the feature.
Fixes #2250
Changes
Enable curl verbose output and add debug function callback to intercept the "interesting" logs.
This functionality is controlled by the compile-time flag/option
WITH_CURL_LOGGING=ON
but can also be enabled at runtime by settingOtlpHttpExporterOptions::console_debug = true
.By default, all the headers and other information are not available and protected by a compile-time flag since they could contain sensitive information.
An example of info logging related to TLS handshake, available by default:
An example of debug logging, enabled via
-DOTEL_CURL_DEBUG
:For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes