-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] speed up clang-tidy
workflow
#3148
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 87.12% 87.82% +0.70%
==========================================
Files 200 195 -5
Lines 6109 6146 +37
==========================================
+ Hits 5322 5397 +75
+ Misses 787 749 -38 |
clang-tidy
workflowclang-tidy
workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the CI speedup improvement.
@sjinks Thanks for the fix, it is most welcome. We are falling behind with basic checks like include-what-you-use (almost done) and clang-tidy (preliminary CI was set in place, but cleanup has barely started yet). Contributions like yours, from someone having both the skills and the willingness to help, are definitively appreciated. |
[CI] speed up `clang-tidy` workflow (open-telemetry#3148)
Changes
This PR speeds up the
clang-tidy
workflow. Becauseclang-tidy
only needs a compilation database generated by CMake, there's no need to waste time compiling the source code.The only target we need to build is
opentelemetry_proto
because some other files depend on the files generated by the Protobuf compiler.We can achieve further performance improvements by running
clang-tidy
jobs in parallel.Before: 43:06 (number of warnings: 114)
After: 14:30 (number of warnings: 114)
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes