[TEST] refactor UrlParser tests to use value-paramterized tests #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
sjinks
commented
Nov 19, 2024
|
|
||
| #include "opentelemetry/ext/http/common/url_parser.h" | ||
|
|
||
| namespace http_common = opentelemetry::ext::http::common; | ||
|
|
||
| inline const char *BoolToString(bool b) | ||
| struct ParsedUrl |
There was a problem hiding this comment.
I used a dedicated structure instead of std::map<std::string, std::string> because map's operator[] may change the map (if a key does not exist, it will create a default-constructed value and put it into the map). Test data must be immutable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3153 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 195 195
Lines 6151 6151
=======================================
Hits 5404 5404
Misses 747 747
|
marcalff
changed the title
|
Waiting a bit for possible comments, then will merge. |
lalitb
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3146
Changes
This PR refactors the UrlParser tests to make them more readable and use value-parametrized tests.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes