-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] add instrumentation scope attributes to otlp proto messages for traces and metrics #3185
[EXPORTER] add instrumentation scope attributes to otlp proto messages for traces and metrics #3185
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
…ages for metrics and traces
809fc1b
to
2f0740f
Compare
d6317b5
to
e04755b
Compare
e04755b
to
dc98669
Compare
I've updated this PR with more tests and its passing CI. Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
One minor comment to address, with approval to follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
Nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Fixes #3184
Changes
Please provide a brief description of the changes here.
PopulateAttribute
method to set attributes on theproto::common::v1::InstrumentationScope
object inotlp_populate_attribute_utils.h
proto::common::v1::InstrumentationScope
in theOtlpRecordableUtils::PopulateRequest
method for traces.proto::common::v1::InstrumentationScope
in theOtlpMetricUtils::PopulateResourceMetrics
method for metricsFor significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes