Add plugin support #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnburn
requested review from
g-easy,
jmacd,
maxgolov,
reyang and
tigrannajaryan
as code owners
g-easy
approved these changes
Feb 18, 2020
examples/plugin/plugin/tracer.h
Outdated
| opentelemetry::nostd::string_view name, | ||
| const opentelemetry::trace::StartSpanOptions &options) noexcept override; | ||
|
|
||
| private: |
There was a problem hiding this comment.
The empty private: section.
There was a problem hiding this comment.
Yeah, that makes sense. Removed.
examples/plugin/load/main.cc
Outdated
| { | ||
| if (argc != 3) | ||
| { | ||
| std::cerr << "Usage: load_plugin <plugin> <confg>\n"; |
ci/do_ci.sh
Outdated
| cmake -DCMAKE_BUILD_TYPE=Debug \ | ||
| -DCMAKE_CXX_FLAGS="-Werror" \ | ||
| "${SRC_DIR}" | ||
| make | ||
| make test | ||
| exit 0 | ||
| elif [[ "$1" == "cmake.build_example_plugin" ]]; then |
g-easy
reviewed
Feb 24, 2020
| { | ||
| namespace detail | ||
| { | ||
| inline void CopyErrorMessage(const char *source, std::string &destination) noexcept |
There was a problem hiding this comment.
Since this isn't a virtual, can it just use std::string?
There was a problem hiding this comment.
It's using a std::string for the destination.
It takes a const char* instead of string_view or string for the source to handle the case when it might be a nullptr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an interface for loading tracer as plugins.
The plugin-tracer interface only use types that have well defined ABIs. Provided the standard-c++ library is suitably linked, plugins can be portable and not tied to a particular standard-c++ library implementation.
Because we're not far enough along with a tracer implementation to test against, this also adds a small dynamic load example for testing. But it can be replaced when there's an SDK implementation.