Add a Recordable interface, implementation, and tests for logs #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 10, 2020 17:36
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 94.52% 94.19% -0.33%
==========================================
Files 178 182 +4
Lines 7701 7853 +152
==========================================
+ Hits 7279 7397 +118
- Misses 422 456 +34
|
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
reviewed
Dec 10, 2020
maxgolov
approved these changes
Dec 10, 2020
lalitb
approved these changes
Dec 11, 2020
| resource.begin(), resource.end()}, | ||
| nostd::span<const std::pair<nostd::string_view, common::AttributeValue>>{ | ||
| attributes.begin(), attributes.end()}, | ||
| trace_id, span_id, trace_flags); |
There was a problem hiding this comment.
Nice to see this initializer_list for resource and attributes.
lalitb
requested review from
pyohannes and
jsuereth
and removed request for
jsuereth
ThomsonTan
reviewed
Dec 11, 2020
ThomsonTan
reviewed
Dec 11, 2020
ThomsonTan
reviewed
Dec 11, 2020
ThomsonTan
approved these changes
Dec 11, 2020
kxyr
changed the title
pyohannes
reviewed
Dec 12, 2020
|
|
||
| log(r); | ||
| // Set default values for unspecified fields, then call the base Log() method | ||
| void Log(Severity severity, nostd::string_view message, core::SystemTimestamp time) noexcept |
There was a problem hiding this comment.
Why do we have time first in the virtual Log call, but severity first here? I think we should keep the order of the arguments consistent.
There was a problem hiding this comment.
Hmm since it seems most ergonomic/common use case is to users to specify severity, then message, since timestamp would be set by default in common use cases. I can move timestamp to the end of the main Log() method for consistent ordering with this method here
jsuereth
reviewed
Dec 12, 2020
kxyr
force-pushed
the
logs-recordable
branch
from
e4e746d to
a03d17e
Compare
|
@pyohannes @lalitb Would this be good to merge now? |
kxyr
changed the title
|
@xukaren - Please rebase the branch with base, so we should be ready to merge it. thanks. |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a recordable for logs, as part of the logging prototype, and also resolving issue #412.
This PR:
LogRecordRecordable implementation, with unit testsRecordableinstead of the previousLogRecordstruct, across the processor and exporter filesAPI/SDK changes:
Severity::kDefaultenum value (originally set as kInfo), and added aSeverity::kInvalid= 0. (Setting the default Severity to kInfo has been moved to the SDK instead of the API)Other minor changes:
LogRecordstruct from the APIlog()methods toLog(), and addsthis->before calling Log() methodsThis PR introduces changes that blocks a few other open PRs: #422, #430, #434, and #435.
cc @MarkSeufert @alolita