Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Zoom passcode #532

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Added Zoom passcode #532

merged 2 commits into from
Jan 26, 2021

Conversation

mtwo
Copy link
Member

@mtwo mtwo commented Jan 25, 2021

No description provided.

@mtwo mtwo requested a review from a team January 25, 2021 23:59
@codecov
Copy link

codecov bot commented Jan 26, 2021 •
edited
Loading

Codecov Report

Merging #532 (6624ef3) into main (47d6554) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   94.46%   94.42%   -0.04%     
==========================================
  Files         194      194              
  Lines        8509     8509              
==========================================
- Hits         8038     8035       -3     
- Misses        471      474       +3
Impacted Files Coverage Δ
sdk/test/metrics/counter_aggregator_test.cc 98.21% <0.00%> (-1.79%) ⬇️
sdk/src/trace/batch_span_processor.cc 91.35% <0.00%> (-1.24%) ⬇️
sdk/src/logs/batch_log_processor.cc 93.82% <0.00%> (-1.24%) ⬇️

reyang
reyang approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Base automatically changed from master to main January 26, 2021 00:46
@lalitb lalitb merged commit 8fd86ed into open-telemetry:main Jan 26, 2021
@mtwo mtwo deleted the patch-1 branch January 26, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtwo @reyang @lalitb