Add http client/server example #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 94.49% 94.51% +0.02%
==========================================
Files 197 197
Lines 9130 9127 -3
==========================================
- Hits 8627 8626 -1
+ Misses 503 501 -2
|
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
ThomsonTan
reviewed
Mar 26, 2021
exporters/ostream/include/opentelemetry/exporters/ostream/span_exporter.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Tan <lilotom@gmail.com>
ThomsonTan
approved these changes
Mar 26, 2021
pyohannes
reviewed
Mar 26, 2021
maxgolov
reviewed
Mar 28, 2021
maxgolov
reviewed
Mar 28, 2021
maxgolov
reviewed
Mar 28, 2021
maxgolov
approved these changes
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #631
Changes
Adds simple client/server example using http client and server library as provided by this repo.
It's very simple functionality for now to create and dump spans at both the end. Next step would be to have nested spans and w3c context propagation.
Also small formatting fix in ostream exporter to dump attributes properly. Currently on xterm, contents get wrapped on same line and not readable properly for larger attributes.
CHANGELOG.mdupdated for non-trivial changes