Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring trace state #637

Closed

Conversation

nikhil1511
Copy link
Contributor

@nikhil1511 nikhil1511 commented Mar 29, 2021

Fixes #79

  • Refactoring trace state code to reuse functionality in baggage implementation
  • Extracted common parsing logic of headers from trace_state into kv_properties
  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@nikhil1511 nikhil1511 requested a review from a team March 29, 2021 17:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 29, 2021

CLA Missing ID

@nikhil1511 nikhil1511 changed the title Ndaliya/trace state refactor Refactoring trace state Mar 29, 2021
@nikhil1511 nikhil1511 changed the title Refactoring trace state [WIP] Refactoring trace state Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #637 (d01a4e3) into main (9fa6bd5) will increase coverage by 0.03%.
The diff coverage is 97.20%.

❗ Current head d01a4e3 differs from pull request most recent head e5d39c0. Consider uploading reports for the commit e5d39c0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   94.49%   94.52%   +0.03%     
==========================================
  Files         197      199       +2     
  Lines        9130     9135       +5     
==========================================
+ Hits         8627     8635       +8     
+ Misses        503      500       -3     
Impacted Files Coverage Δ
api/include/opentelemetry/common/string_util.h 66.66% <66.66%> (ø)
api/include/opentelemetry/trace/trace_state.h 98.80% <98.14%> (+1.26%) ⬆️
api/include/opentelemetry/common/kv_properties.h 98.27% <98.27%> (ø)
api/test/trace/trace_state_test.cc 100.00% <100.00%> (+2.22%) ⬆️
sdk/src/logs/batch_log_processor.cc 95.00% <0.00%> (+1.25%) ⬆️

@nikhil1511 nikhil1511 closed this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Baggage ( prev: CorrelationContext )
1 participant