fix for sampling root span #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 95.95% 96.00% +0.04%
==========================================
Files 176 176
Lines 7172 7186 +14
==========================================
+ Hits 6882 6899 +17
+ Misses 290 287 -3
|
ThomsonTan
reviewed
May 21, 2021
| } | ||
| else | ||
| { | ||
| return {Decision::DROP}; |
There was a problem hiding this comment.
Should we assert(false) here? Seems invalid trace Id should not be passed to sampler.
There was a problem hiding this comment.
Instead of asserting in unit-test, better would be to fail the particular unit-test and let other tests run? Like in this case, ValidTraceIdToSampler test will fail.
There was a problem hiding this comment.
Yes, fail this particular unit-test works too.
There was a problem hiding this comment.
ok got it. Have changed it.
ThomsonTan
approved these changes
May 21, 2021
maxgolov
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #782
Changes
Move span_context creation from sdk::Span to sdk::Tracer, and pass it in sdk::Span constructor. This also allows passing valid trace_id of root span to Sampler, and in accordance with how other languages implement.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes