-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Scope object instead of unique_ptr<Scope> from Tracer::WithActiveSpan() #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #788 +/- ##
==========================================
+ Coverage 95.99% 96.00% +0.01%
==========================================
Files 176 176
Lines 7186 7183 -3
==========================================
- Hits 6898 6896 -2
+ Misses 288 287 -1
|
…etry-cpp into remove-scope-unique-ptr
…etry-cpp into remove-scope-unique-ptr
pyohannes
approved these changes
May 24, 2021
ThomsonTan
reviewed
May 24, 2021
jsuereth
approved these changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to have a secondary method to apply active-span to context that DOESN'T have auto-scope (for advanced use cases).
Like this cleanup!
ThomsonTan
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Changes
As mentioned in why nostd::unique_ptr<Scope> not Scope #787 ,
Tracer::WithActiveSpan()
can avoid memory allocation on heap by returning newly createdScope
object instead ofunique_ptr<Scope>
. The copy constructor ofScope
is implicitly deleted because ofunique_ptr
member variable, so this ensures multiple copies are not possible forScope
.Also modified etw::tracer::StartSpan() method to not make span active immediately after creating as this deviates from the specs.
tracer::WithActiveSpan()
should be called explicitly by instrumentation library to make it active. ( cc @maxgolov )For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes