Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #include <cctype> to baggage.h #822

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Conversation

lidavidm
Copy link
Contributor

@lidavidm lidavidm commented Jun 3, 2021

Fixes #808

Changes

Add #include <cctype> to make isdigit, isalnum, etc. available in baggage.h.

I also tested against the Abseil-variant branch and confirmed that 1) without this, we still get errors under MSVC2015 and 2) with this, there are no errors.

  • (N/A) CHANGELOG.md updated for non-trivial changes
  • (N/A) Unit tests have been added
  • (N/A) Changes in public API reviewed

@lidavidm lidavidm requested a review from a team June 3, 2021 19:22
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #822 (9e3b0f9) into main (0f6199f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         153      153           
  Lines        6444     6444           
=======================================
  Hits         6198     6198           
  Misses        246      246           
Impacted Files Coverage Δ
api/include/opentelemetry/baggage/baggage.h 97.30% <ø> (ø)

@maxgolov
Copy link
Contributor

maxgolov commented Jun 3, 2021

Thank you for the fix. We'd consider adding some tests / samples. Perhaps it's one of these extended features that we are not compiling in any of the examples. I'll set up the build loop for vs2015 once the Abseil branch changes get merged this week, to continuously validate everything with vs2015.

@lalitb lalitb merged commit 3de8f35 into open-telemetry:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

baggage.h is missing #include <cctype> for MSVC2015
3 participants