Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document vcpkg toolchain configuration #913

Merged
merged 6 commits into from
Jul 20, 2021
Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 20, 2021

Fixes #874

Changes

Documenting the

  • steps to configure the externally installed vcpkg toolchain for build.
  • usage of internally configured vcpkg toolchain for windows build.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team July 20, 2021 12:33
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #913 (9e3082d) into main (40d2eb5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #913   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         158      158           
  Lines        6749     6749           
=======================================
  Hits         6441     6441           
  Misses        308      308           

docs/building-with-vcpkg.md Outdated Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Reiley Yang <reyang@microsoft.com>
@lalitb lalitb merged commit 2037fa7 into open-telemetry:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors building -DWITH_JAEGER on Windows - Thrift missing
2 participants