Support determining parent span from Context while creating new Span #969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #955
Changes
This adds support for passing
Context
wrapping parentSpan
object while creating new Span.SpanContext
object is also kept in place. Also to avoid storing two different variables forContext
andSpanContext
inside StartSpanOptions struct, variant object is introduced within this struct.span.h
requiringcontext/context.h
andcontext/context.h
requiringspan.h
throughcontext/context_value.h
) : this required addingspan_startoptions.h
andspan_metadata.h
.cc @jsuereth
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes