Enable CMake to search the new package variable <PackageName>_ROOT #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #975 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 161 161
Lines 6817 6817
=======================================
Hits 6502 6502
Misses 315 315 |
lalitb
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have dependency on cURL which dpendes on zlib. The latest vcpkg port of zlib introduced
ZLIB_ROOTin this PR. The default policy of CMake 3.12 and above is warning on the user of this variable and ignore it. This PR asks CMake to follow the new behavior and honorZLIB_ROOTaccordingly.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes