Remove scheme from OTLP endpoint before passing to gRPC #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #988 +/- ##
=======================================
Coverage 95.41% 95.41%
=======================================
Files 161 161
Lines 6833 6833
=======================================
Hits 6519 6519
Misses 314 314 |
lalitb
reviewed
Sep 21, 2021
| { | ||
| grpc_target = options.endpoint; | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit, we can also use UrlParser :
UrlParser url(options.endpoint);
if (url.success_) {
grpc_target = url.host_ + ":" + url.port_;
}This will validate that url is in correct format, and remove path and query_string if added ?
lalitb
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #986
Changes
According to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md, URI scheme like
httporhttpsare allowed in the OTLP endpoint, but causes problem in naming resolving in gRPC. This change removes the URI scheme for OTLP gRPC.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes