Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otelcol) prometheus metrics export descriptions #1120

Merged
merged 4 commits into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ release.
([#1114](https://github.com/open-telemetry/opentelemetry-demo/pull/1114))
* [cartservice] update .NET package to 1.6.0 release
([#1115](https://github.com/open-telemetry/opentelemetry-demo/pull/1115))
* Set metric description to blank for rpc.server.duration and queueSize
([#1120](https://github.com/open-telemetry/opentelemetry-demo/pull/1120))

## 1.5.0

Expand Down
18 changes: 11 additions & 7 deletions src/otelcollector/otelcol-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,16 @@ exporters:

processors:
batch:
filter:
metrics:
exclude:
match_type: strict
metric_names:
- queueSize
transform:
metric_statements:
- context: metric
statements:
# FIXME: remove this when this is issue is resolved: https://github.com/open-telemetry/opentelemetry-java/issues/4834
- set(description, "") where name == "queueSize"
# FIXME: remove this when the following 2 issues are resolved
# Java: https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/9478
# Go: https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4301
- set(description, "") where name == "rpc.server.duration"

connectors:
spanmetrics:
Expand All @@ -35,7 +39,7 @@ service:
exporters: [logging, spanmetrics]
metrics:
receivers: [otlp, spanmetrics]
processors: [filter, batch]
processors: [transform, batch]
exporters: [logging]
logs:
receivers: [otlp]
Expand Down
Loading