(jaeger): Fix jaeger span metrics #1174
Merged
+209
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
|
@puckpuck just one question, what is the file: |
Prometheus will error out if a config file is not passed into the startup, since the default image does not have one. Typically Prometheus is used to pull metrics, so a config will always be present, but since we are using it only in a push method, we don't have a scraping config to pass in. |
Dylan-M
pushed a commit
to observIQ/opentelemetry-demo
that referenced
this pull request
Oct 25, 2023
* jaeger spm and prometheus Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * jaeger spm and prometheus Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Dylan-M
pushed a commit
to observIQ/opentelemetry-demo
that referenced
this pull request
Oct 25, 2023
* jaeger spm and prometheus Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * jaeger spm and prometheus Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
|
Turns out this file was kinda important as it was scraping collector metrics. Removing it broke the collector dashboard in Grafana. |
This was referenced Dec 9, 2023
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* jaeger spm and prometheus Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * jaeger spm and prometheus Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes: #864
Adds proper command args to Jaeger to understand the proper metric names generated from the
spanmetricsconnectors.Merge Requirements
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.