-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java-services] Update java, gradle and OTel agent versions #1183
[java-services] Update java, gradle and OTel agent versions #1183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
It's a great improvement to use Log4j2 so logs can be captured via auto-instrumentation and send through OTLP. Did you consider enabling |
AFAIK In this PR I'm also adding log4j2 to the Kotlin service, so we also have OTLP traces for FraudDetection. Am I missing something @cyrille-leclerc ? |
The java-otel README for the autoconfigurer states:
To my understanding, we should be good with the current change that @julianocosta89 is proposing 👍 |
You are right, nothing to do in the demo. Logs auto instrumentation got enabled by default in 1.27.0 but the release notes of the auto-instrumentation agent didn't mention it, it just appeared on the release notes of he auto-configure-sdk: |
Sorry @julianocosta89 and @cedricziel, OTel Logs are disabled by default on the OTel Java Auto Instrumentation agent. Logs will be enabled by default in 2.0. Shall we enable it on the OTel Demo? See And |
@cyrille-leclerc the logs are already enabled for AdService, and this PR adds it to the FraudDetectionService. I'm not sure what you would like to add. Please feel free to send a PR with your suggestions. |
…emetry#1183) * Update AdService to Java version 21 * Add log and update dependencies * Bump java agent * Changelog * lint
…emetry#1183) * Update AdService to Java version 21 * Add log and update dependencies * Bump java agent * Changelog * lint
Logs were added to Fraud Detection Service in open-telemetry/opentelemetry-demo#1183
…emetry#1183) * Update AdService to Java version 21 * Add log and update dependencies * Bump java agent * Changelog * lint
Changes
This PR updates the java version on AdService to latest LTS Java (21).
Unfortunately, there is jvm target
21
for Kotlin yet, so for FraudDetection I've just update gradle to version8.4
.Also bumped the Java OTel agent in the 3 services its being used.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.