[go services]: workaround: disable grpc metrics #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
…-go-metrics # Conflicts: # CHANGELOG.md
cedricziel
approved these changes
Oct 30, 2023
fatsheep9146
approved these changes
Oct 31, 2023
|
@puckpuck, is there already a Go issue that could be added here as a reference? |
roc-muto
added a commit
to roc-muto/opentelemetry-demo
that referenced
this pull request
Nov 2, 2023
commit 1e57218 Author: Sebastian Poxhofer <secustor@users.noreply.github.com> Date: Wed Nov 1 19:23:03 2023 +0100 ci: migrate Renovate config (open-telemetry#1207) Co-authored-by: Austin Parker <austin@ap2.io> commit 526a8d3 Author: Pierre Tessier <pierre@pierretessier.com> Date: Wed Nov 1 12:19:37 2023 -0400 [go services]: workaround: disable grpc metrics (open-telemetry#1205) * workaround: disable grpc metrics Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * workaround: disable grpc metrics Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* workaround: disable grpc metrics Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * workaround: disable grpc metrics Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Due to a memory leak with high cardinality in the
rpc.server.durationmetric generated by the Go SDK, this adds a Metric View to disable those metrics in the checkout and productcatalog services. When the Go SDK is fixed, we should undo this change.Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.