Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust shipping service #129

Closed

Conversation

GaryPWhite
Copy link
Contributor

Fixes #35

Changes

ShippingService is now written in Rust -- providing a demo / reference implementation for rustaceans.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@GaryPWhite
Copy link
Contributor Author

I have some admin work for Wayfair this week that means I may not make much progress. I plan to write the docker config and OTel integrations now that this is minimally functional, then button up the implementation like the Go implementation to actually make quotes / tracking ID's.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 21, 2022
@GaryPWhite
Copy link
Contributor Author

ok I will just let the pr lapse if it's going to worry about it

@cartersocha
Copy link
Contributor

@reyang can we update the bot to be less aggressive on prs or is this our preferred process?

@cijothomas
Copy link
Member

@reyang can we update the bot to be less aggressive on prs or is this our preferred process?

https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/.github/workflows/stale.yml#L18 can be updated.

Btw, even if a PR is closed by stalebot, it can be reopened back. It just keeps the open PRs list short and clean.

@reyang
Copy link
Member

reyang commented Jun 22, 2022

@reyang can we update the bot to be less aggressive on prs or is this our preferred process?

We can. The question is what do we want. The current configuration is based on the best practices we've learned from other repos.

Take this PR for example, my suggestion would be let this PR be stale and closed automatically by the bot at this moment, and when @GaryPWhite has time, he could decide either to resurrect/reopen this PR or open another PR.

@cartersocha
Copy link
Contributor

Keeping a shortlist with the ability to re-open whenever sounds good to me. I’d prefer to just follow normal best practices in general but wanted to check the existing reason

@github-actions github-actions bot removed the Stale label Jun 23, 2022
@GaryPWhite
Copy link
Contributor Author

totally reasonable @reyang . Wonder how you might feel about "draft" pr's being treated differently.

@reyang
Copy link
Member

reyang commented Jun 23, 2022

totally reasonable @reyang . Wonder how you might feel about "draft" pr's being treated differently.

I don't have strong opinion here. I guess if the "draft" PR has updates every other day, it won't be marked as Stale by the bot?

If we want to adjust the balance (e.g. extending the time to 4 weeks for "draft" PR), I'm supportive (I can imagine that folks created a draft PR just to facilitate a discussion / prototype).

If the goal is to allow "draft" PR sitting there forever, I'll need to be convinced 😄

@GaryPWhite
Copy link
Contributor Author

If the goal is to allow "draft" PR sitting there forever, I'll need to be convinced 😄

Definitely not the goal to have something sit forever :) It seems like you're looking at the PR queue as something that needs attention immediately when the PR is opened -- I'm keeping this open while I'm working on it so folks can, at their absolute leisure, check in if they're curious, or if they think i'm missing something. It seems to me that it makes more sense to open PR's when they're ready for review here -- and drafts are not necessarily preferred.

I'll open a full PR when it's ready.

@GaryPWhite GaryPWhite closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement 'shippingservice' in Rust
4 participants