adservice add highcpu load ff #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new ff to the adservice. When enabled, the adservice uses an abnormal amout of CPU. Should you want to demo cpu throtteling, you need to add cpu limits to the pod/container
github-actions
bot
added
docs-update-required
julianocosta89
approved these changes
Apr 10, 2024
julianocosta89
approved these changes
Apr 10, 2024
puckpuck
approved these changes
Apr 11, 2024
AlexPSplunk
pushed a commit
to splunk/edu-opentelemetry-demo
that referenced
this pull request
Jul 10, 2024
* adservice add highcpu load ff This commit adds a new ff to the adservice. When enabled, the adservice uses an abnormal amout of CPU. Should you want to demo cpu throtteling, you need to add cpu limits to the pod/container * update changelog --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new featureflag,
adServiceHighCpu, to the adservice. When enabled, the adservice uses an abnormal amount of CPU. This is an interesting, real world observability scenario because it simulates high cpu usage problems in the application which afaik no feature flag does this way.Should you want to demo cpu throttling, you need to add cpu limits to the pod/container in which the adservice is running.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.