[quoteservice] manual metrics, logs export #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a manual metric to the php quote service - randomize per-item cost to add some variability to quotes - bump dependencies to latest - fix a monolog deprecation - ensure logs are exported per the configured delay
|
Related to open-telemetry/opentelemetry.io#2669 |
puckpuck
requested changes
Apr 11, 2024
puckpuck
approved these changes
Apr 11, 2024
puckpuck
approved these changes
Apr 11, 2024
|
I pushed a fix to your branch for the quote service CI trace-based test. Since the returned cost is now randomized, the quote cost check needed to reflect this. |
Thanks, I didn't consider if there might be downstream effects of randomizing the cost. |
julianocosta89
approved these changes
Apr 11, 2024
AlexPSplunk
pushed a commit
to splunk/edu-opentelemetry-demo
that referenced
this pull request
Jul 10, 2024
* [quoteservice] adding manual metrics to quoteservice - add a manual metric to the php quote service - randomize per-item cost to add some variability to quotes - bump dependencies to latest - fix a monolog deprecation - ensure logs are exported per the configured delay * update changelog * fix * rename variable * remove total cost from metric attributes * quote service returns randomized cost --------- Co-authored-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.