Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append slash to copy destination in adService Dockerfile #1530

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

danielgblanco
Copy link
Contributor

As described in Docker docs:

If multiple resources are specified, either directly or due to the use of a wildcard, then must be a directory, and it must end with a slash /.

Having no slash at the end of this command may make Docker build fail under certain circumstances.

Changes

Adds / to Dockefile in adService

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

As described in Docker docs:

If multiple <src> resources are specified, either directly or due to the use of a wildcard, then <dest> must be a directory, and it must end with a slash /.

Having no slash at the end of this command may make Docker build fail under certain circumstances.
@danielgblanco danielgblanco requested a review from a team April 15, 2024 15:03
@julianocosta89 julianocosta89 merged commit 95a3b5c into open-telemetry:main Apr 15, 2024
27 checks passed
@danielgblanco danielgblanco deleted the patch-2 branch April 16, 2024 09:57
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
…try#1530)

As described in Docker docs:

If multiple <src> resources are specified, either directly or due to the use of a wildcard, then <dest> must be a directory, and it must end with a slash /.

Having no slash at the end of this command may make Docker build fail under certain circumstances.

Co-authored-by: Austin Parker <austin@ap2.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants