-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helm chart to main readme #255
Conversation
@wph95 @TylerHelmuth any suggestions on information or doc structure? I tried to adapt the helm repo information & spotlight it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good start. I think anything more (like common values.yaml options) would be better suited in the chart's readme. I do think it would be good to link directly to https://github.com/open-telemetry/opentelemetry-helm-charts/tree/main/charts/opentelemetry-demo somewhere in this doc.
* add helm chart * changelog update * pr feedback * nit * add to prerequisites
Pointing to our helm chart in our docs