-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend] - add span links on synthetic requests #332
[frontend] - add span links on synthetic requests #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @puckpuck this is looking great! I left a small non-blocking comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, I'd just love to do a dry run before merging it
I put together this branch: https://github.com/honeycombio/opentelemetry-demo/tree/baggage-end-to-end which combines #331 and #332
|
@puckpuck can you resolve conflicts? |
* add span links * add span links to frontend
Related to #329
Changes
synthetic_request=true
baggage (from load generator)CHANGELOG.md
updated for non-trivial changesDepends on #331