Custom attributes and spans for FeatureFlag service #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the change log and attribute doc too! docs/manual_span_attributes.md |
joshleecreates
added a commit
to joshleecreates/opentelemetry-demo
that referenced
this pull request
Sep 19, 2022
joshleecreates
added a commit
to joshleecreates/opentelemetry-demo
that referenced
this pull request
Sep 19, 2022
joshleecreates
force-pushed
the
main
branch
from
f908ee8 to
f58d8b2
Compare
joshleecreates
force-pushed
the
main
branch
from
f224382 to
0cecb0d
Compare
|
Can we get the failing check cleaned up? |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328.
Changes
Adds a custom span when new feature flags are created via the UI, and adds custom attributes for the feature flag to the auto instrumentation span on the grpc service.