Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cartservice Dockerfile to support ARM64 #439

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Oct 13, 2022

Use multiarch runtime-deps image, and configure the runtime identifier based on the images architecture using uname -m.

@chancez chancez requested a review from a team October 13, 2022 21:03
@chancez chancez changed the title Update cartservice Dockerfile for ARM64 Update cartservice Dockerfile to support ARM64 Oct 13, 2022
@chancez chancez force-pushed the pr/chancez/support_arm64 branch from 6983866 to de99b2f Compare October 13, 2022 21:03
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez force-pushed the pr/chancez/support_arm64 branch from de99b2f to 4972d66 Compare October 13, 2022 21:05
@puckpuck
Copy link
Contributor

Is the cart service the only one that is problematic with ARM ?

@chancez
Copy link
Contributor Author

chancez commented Oct 14, 2022

So far the rest build fine on arm64 without changes. That said, the currently released images aren't all built for arm64 yet IIRC.

@saurabhdes
Copy link
Contributor

saurabhdes commented Oct 15, 2022

that's correct @chancez - The currently released images are not built for ARM. We have a bug for it #396

@puckpuck puckpuck merged commit 2c36295 into open-telemetry:main Oct 18, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
…y#439)

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Co-authored-by: Juliano Costa <juliano.costa@dynatrace.com>
Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants