[frontend] use frontend-web for web client service name #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
austinlparker
approved these changes
Dec 12, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…ry#628) * use frontend-web for web client service name Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * use frontend-web for web client service name Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Signed-off-by: Pierre Tessier <pierre@pierretessier.com> Co-authored-by: Austin Parker <austin@ap2.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
frontend-webas the service name for all requests from the web/browser.This makes it much easier to find browser-based requests vs load generator ones. May also help with service maps for some vendors.
CHANGELOG.mdupdated to document new feature additions