Add resource detectors to cart service #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
fatsheep9146
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Tried it out locally and nothing was added to the Resource Attributes. I suspect this is not working on my Ubuntu, because a similar issue happened when testing #662
|
Is it any specific version of docker required to this to work? |
julianocosta89
approved these changes
Jan 2, 2023
|
Doesn't work for me when using docker desktop on mac. |
|
This is probably due to a Limitation because of cgroup v2, there is a solution in the making for dotnet: open-telemetry/opentelemetry-dotnet-contrib#839 Java & NodeJS have that fixed already. |
|
Thanks @svrnm. Lgtm and the dependency PR seems to be making progress. Merging. |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resource detection for cart service, right now it is only the container.id because it looks like no other resource detectors exist for .NET (yet)
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions