Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix minor bugs #670

Merged
merged 2 commits into from
Jan 4, 2023
Merged

[frontend] Fix minor bugs #670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47a3e0
Fix minor FE bugs
Jan 3, 2023
2580831
Merge branch 'main' into frontend-minor-adjusts
cartersocha Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
docs
internal

###################################
# shippingservice
./src/shippingservice/target
###################################

###################################
# currencyservice
./src/currencyservice/client.js
Expand All @@ -22,6 +17,15 @@ internal
./src/featureflagservice/tmp/
./src/featureflagservice/.elixir_ls

###################################
# frontend
./src/frontend/node_modules/

###################################
# shippingservice
./src/shippingservice/target
###################################

# Mix artifacts
./src/featureflagservice/_build/
./src/featureflagservice/deps/
Expand Down
1 change: 0 additions & 1 deletion src/frontend/components/CartDropdown/CartDropdown.styled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export const CartDropdown = styled.div`
width: 100%;
height: 100%;
max-height: 100%;
overflow-y: scroll;
padding: 25px;
display: flex;
flex-direction: column;
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/components/CartDropdown/CartDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const CartDropdown = ({ productList, isOpen, onClose }: IProps) => {
</S.ItemList>
</div>
<Link href="/cart">
<S.CartButton data-cy={CypressFields.CartGoToShopping}>Go to Shipping Cart</S.CartButton>
<S.CartButton data-cy={CypressFields.CartGoToShopping}>Go to Shopping Cart</S.CartButton>
</Link>
</S.CartDropdown>
) : null;
Expand Down
1 change: 1 addition & 0 deletions src/frontend/pages/_document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export default class MyDocument extends Document<{ envString: string }> {
href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,300;0,400;0,500;0,600;0,700;0,800;1,300;1,400;1,500;1,600;1,700;1,800&display=swap"
rel="stylesheet"
/>
<title>OTel demo</title>
</Head>
<body>
<Main />
Expand Down