Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Program.cs #754

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Clean up Program.cs #754

merged 3 commits into from
Feb 22, 2023

Conversation

davidfowl
Copy link
Contributor

@davidfowl davidfowl commented Feb 22, 2023

Removed unnecessary API calls and added await.

Changes

Please provide a brief description of the changes here.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Removed unnecessary API calls and added await.
@davidfowl davidfowl requested a review from a team February 22, 2023 03:51
@cartersocha
Copy link
Contributor

Please add a change log entry too

Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a big fan of a change that reduces the lines of code and makes it easier to read.

Thanks for the this.

@davidfowl
Copy link
Contributor Author

Please add a change log entry too

Let me know if there's something else that needs to be done.

@cartersocha cartersocha merged commit 132cf4d into open-telemetry:main Feb 22, 2023
@davidfowl davidfowl deleted the patch-1 branch February 23, 2023 17:05
styblope pushed a commit to instana/opentelemetry-demo that referenced this pull request Mar 12, 2023
juliangiuca pushed a commit to juliangiuca/opentelemetry-demo that referenced this pull request Apr 12, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants