-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing quoteservice metrics exporting #793
fixing quoteservice metrics exporting #793
Conversation
metrics exporting was quietly failing due to misconfiguration. Update some packages to pick up the relevant bugfix, and use OTEL_EXPORTER_OTLP_ENDPOINT so that metrics, traces and eventually logs can use it. In passing, enable some logging which makes future errors more obvious.
Thanks for taking care of this @brettmc! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to build it locally and started getting the following msg in the logs:
[2023-03-15T10:50:43.962596+00:00] otel-php.WARNING: tracestate discarded, invalid member: {"source":"OpenTelemetry\\API\\Trace\\TraceState"} []
Is that expected?
@julianocosta89 no it's not expected...but I did turn on some logging so it's possible that it's a problem that's always been there but not noticed. I didn't see this when just calling the service directly (which would make sense, there is no distributed tracing). To replicate, do I just bring up everything and watch it run? |
You can run:
Once everything is running, you can get the logs from quoteservice:
|
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
upstream bugfix: open-telemetry/opentelemetry-php#936 |
ok, patched in a new version of one of our packages, the warning message is gone, and we have one less bug in our code. I think this is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
* fixing quoteservice metrics exporting metrics exporting was quietly failing due to misconfiguration. Update some packages to pick up the relevant bugfix, and use OTEL_EXPORTER_OTLP_ENDPOINT so that metrics, traces and eventually logs can use it. In passing, enable some logging which makes future errors more obvious. * changelog * Update CHANGELOG.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * fixing changelog link * update to latest api with warning fixed --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
* fixing quoteservice metrics exporting metrics exporting was quietly failing due to misconfiguration. Update some packages to pick up the relevant bugfix, and use OTEL_EXPORTER_OTLP_ENDPOINT so that metrics, traces and eventually logs can use it. In passing, enable some logging which makes future errors more obvious. * changelog * Update CHANGELOG.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * fixing changelog link * update to latest api with warning fixed --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
* fixing quoteservice metrics exporting metrics exporting was quietly failing due to misconfiguration. Update some packages to pick up the relevant bugfix, and use OTEL_EXPORTER_OTLP_ENDPOINT so that metrics, traces and eventually logs can use it. In passing, enable some logging which makes future errors more obvious. * changelog * Update CHANGELOG.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * fixing changelog link * update to latest api with warning fixed --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Changes
metrics exporting was quietly failing due to misconfiguration. Update some packages to pick up the relevant bugfix, and use OTEL_EXPORTER_OTLP_ENDPOINT so that metrics, traces and eventually logs can use it.
In passing, enable some logging which makes future errors more obvious.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.
Fixes: #775