-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update kubernetes manifest #848
[chore] update kubernetes manifest #848
Conversation
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
… update_kubernetes_manifest
* update k8s manifest to latest Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update k8s manifest to latest Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add copyright to generated k8s manifests Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Hello! I hope you're doing well. I noticed that in your configuration, "tcp-" is added before the service port name instead of "grpc-". For instance, the opentelemetry-demo-paymentservice changes from "service" to "tcp-service". I observed that in the GoogleCloudPlatform/microservices-demo, it's written as "grpc". Could there be any potential issues if I change it to "grpc-" instead of "tcp-"? The reason I'm considering this change is that currently, I'm only detecting TCP traffic and not seeing any GRPC traffic in Istio. Your insights on this would be greatly appreciated! |
* update k8s manifest to latest Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * update k8s manifest to latest Signed-off-by: Pierre Tessier <pierre@pierretessier.com> * add copyright to generated k8s manifests Signed-off-by: Pierre Tessier <pierre@pierretessier.com> --------- Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
With a Helm chart released for 1.4 of the demo, this is an output of that release. Also forces the namespace to be
otel-demo
and when combined with a docs change will fix #840CHANGELOG.md
updated to document new feature additions